Return-Path: Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 51976 invoked by uid 500); 22 May 2001 07:56:13 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 51951 invoked from network); 22 May 2001 07:56:10 -0000 Errors-To: Message-ID: <00a201c0e294$634d6e70$94c0b0d0@roweclan.net> Reply-To: "William A. Rowe, Jr." From: "William A. Rowe, Jr." To: References: <20010522074031.27978.qmail@apache.org> Subject: Re: cvs commit: apr-iconv/lib iconv_module.c Date: Tue, 22 May 2001 02:48:40 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N > jfclere 01/05/22 00:40:31 > > Modified: lib iconv_module.c > Log: > Change EFTYPE into APR_ICONV_EFTYPE (EFTYPE is used by FreeBSD). > > - return EFTYPE; > + return APR_ICONV_EFTYPE; Guys, in case we missed the point from the earlier conversion, we have to quit inventing 'custom specific error codes' when plain old obvious codes can be assigned!!! If that means APR_EFTYPE, then fine, but please, lets not get too specific! Bill