apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: [PATCH] First pass at moving util_uri to apr-util...
Date Mon, 21 May 2001 16:18:23 GMT
On Sun, 20 May 2001, Greg Stein wrote:

> When moving functions from one place to another (or whole files!), we can't
> make any changes during the move. It is practically impossible to see and
> review the changes made in transit.
>
> The more ideal way to do this would be to simply "cvs add" util_uri.c as
> uri/apr_uti.c. *Then* to apply patches to make all the changes that you
> suggest. Similar for util_uri.h -> apr_uri.h.
>
> I believe the first step would be to add those two files to APRUTIL, then
> change apr_uri.h to include a #ifdef NOT_READY_YET so the exports processing
> doesn't "see" the changes.
>
> That would make the files available for applying patches.
>
> We should be able to move the gen_uri_delims over directly.
>
> How does that sound?

++1

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message