apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: [PATCH] APR Stackable Memory System
Date Sun, 20 May 2001 22:59:39 GMT

I've committed the first two patches.  While I was at it, I threw in a
couple more styleguide cleanups that I spotted with the second commit.

On Sun, 20 May 2001, Sander Striker wrote:

> sms-abort.patch.2
>     Adds an abort_fn member to the apr_sms_t. This
> includes code calling the abort_fn, if present, on
> APR_ENOMEM. The code to set the abort function is
> not present yet. I added this to get sms one step
> closer to apr pools.

I'm wondering on this one if the abort function should have a prototype
more like the one used by pools (ie, it should take just a status code
rather than filename/linenum).  I'm really only hesitant because I don't
know for sure whether or not __FILE__ and __LINE__ are universally
available symbols across all preprocessors.  Besides, knowing which file
and line it aborted in isn't much help since it will always be within one
of the memory functions, when we're more interested in which file and line
*called* the memory allocation function that failed (I think).


> sms-create.patch.3
>     Cleans up apr_sms_create() [only to be called by
> memory system implementors]. It now returns a status
> code which will be needed when adding lock creation
> and other things that could fail in this function.

I'll get to this one after the abort patch is taken care of.


   Cliff Woolley
   Charlottesville, VA

View raw message