apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: cvs commit: apr/memory/unix apr_sms.c
Date Sat, 19 May 2001 19:21:07 GMT
On 19 May 2001 ben@apache.org wrote:

>   --- apr_sms.c	2001/05/19 13:53:06	1.3
>   +++ apr_sms.c	2001/05/19 15:35:45	1.4
>   @@ -193,7 +193,7 @@
>        mem_sys->accounting_mem_sys = mem_sys;
>
>        if (parent_mem_sys != NULL){
>   -        if (mem_sys->sibling_mem_sys = parent_mem_sys->child_mem_sys){
>   +        if ((mem_sys->sibling_mem_sys = parent_mem_sys->child_mem_sys)){
>                mem_sys->sibling_mem_sys->ref_mem_sys = &mem_sys->sibling_mem_sys;
>            }
>            mem_sys->ref_mem_sys = &parent_mem_sys->child_mem_sys;

Just to verify (haven't looked at this section of the code itself yet),
assignment IS what's intended here, right?  If so, a ((foo = bar) != NULL)
might make that more clear.

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Mime
View raw message