apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Collins-Sussman <suss...@collab.net>
Subject Re: [PATCH] apr_dir_remove_recursively
Date Wed, 23 May 2001 14:15:20 GMT
Greg Stein <gstein@lyra.org> writes:
 
> This should be in the Apache coding style before committing. Notably: no
> space between symbol and opening paren, braces on the if/else lines, and the
> return status lines on a separate line.

Oh, you mean the exact *opposite* of GNU / Subversion coding style. ;)


> 1) APR_STATUS_IS_SUCCESS is kind of a bogus macro; by definition,
>    APR_SUCCESS is zero. Testing it can be done more clearly than using the
>    macro.

Really?  I prefer just to check for zeroness myself, but I swear I
remember being scolded for not using this macro.  Maybe it's just a
holdover from Karl's paranoia.

> 2) the strcmp() calls can be tossed:

Check.


Mime
View raw message