apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfrederic.cl...@fujitsu-siemens.com>
Subject Re: cvs commit: apr-iconv/lib iconv_module.c
Date Tue, 22 May 2001 10:57:32 GMT
"William A. Rowe, Jr." wrote:
> 
> See apr/include/apr_errno.h for the appropriate templates, just follow right
> along :-)  EFTYPE would be appropriate all over, say if a loaded module doesn't
> have the appropriate entry point or data export to be an apache module, etc.

Ok, I will add APR_EFTYPE to APR. and arrange apr_iconv

The patch for apr/include/apr_errno.h could be the one proposed in attachement.
Please check it.
 

> 
> Bill
> 
> ----- Original Message -----
> From: "jean-frederic clere" <jfrederic.clere@fujitsu-siemens.com>
> To: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
> Cc: <dev@apr.apache.org>
> Sent: Tuesday, May 22, 2001 4:18 AM
> Subject: Re: cvs commit: apr-iconv/lib iconv_module.c
> 
> > "William A. Rowe, Jr." wrote:
> > >
> > > > jfclere     01/05/22 00:40:31
> > > >
> > > >   Modified:    lib      iconv_module.c
> > > >   Log:
> > > >   Change EFTYPE into APR_ICONV_EFTYPE (EFTYPE is used by FreeBSD).
> > > >
> > > >   - return EFTYPE;
> > > >   + return APR_ICONV_EFTYPE;
> > >
> > > Guys, in case we missed the point from the earlier conversion, we have to
> > > quit inventing 'custom specific error codes' when plain old obvious codes
> > > can be assigned!!!  If that means APR_EFTYPE, then fine, but please, lets
> > > not get too specific!
> >
> > Apr-iconv logic was using EFTYPE to tell that the converter needs another
> > converter.
> > In FreeBSD I have found:
> > #define EFTYPE          79              /* Inappropriate file type or format */
> >
> > What should I do? Add APR_EFTYPE to APR, but the modules that uses it is an
> > internal module of apr-iconv.
> >
> > >
> > > Bill
> >
Mime
View raw message