apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfrederic.cl...@fujitsu-siemens.com>
Subject Re: cvs commit: apr-iconv/lib iconv_module.c
Date Tue, 22 May 2001 09:18:55 GMT
"William A. Rowe, Jr." wrote:
> 
> > jfclere     01/05/22 00:40:31
> >
> >   Modified:    lib      iconv_module.c
> >   Log:
> >   Change EFTYPE into APR_ICONV_EFTYPE (EFTYPE is used by FreeBSD).
> >
> >   - return EFTYPE;
> >   + return APR_ICONV_EFTYPE;
> 
> Guys, in case we missed the point from the earlier conversion, we have to
> quit inventing 'custom specific error codes' when plain old obvious codes
> can be assigned!!!  If that means APR_EFTYPE, then fine, but please, lets
> not get too specific!

Apr-iconv logic was using EFTYPE to tell that the converter needs another
converter.
In FreeBSD I have found:
#define EFTYPE          79              /* Inappropriate file type or format */

What should I do? Add APR_EFTYPE to APR, but the modules that uses it is an
internal module of apr-iconv.

> 
> Bill

Mime
View raw message