apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/test teststr.c .cvsignore Makefile.in
Date Wed, 23 May 2001 22:33:58 GMT
On Wed, May 23, 2001 at 03:33:29PM -0400, Victor J. Orlikowski wrote:
>  >  > Some eager person may wish to replace the strchr() calls with inline
>  >  > code.  The only compiler I'm really familiar with w.r.t. code
>  >  > generation will replace strchr() with inline code but I suspect that
>  >  > is not the case with most compilers.
>  > 
>  > Macros decided not to play nice.
>  > 
>  > If this works for you, lemme know, and I'll commit it.
> 
> Please ignore; this patch had several errors.

And we *should* use strchr(). Unwrapping that into a loop is bogus. Even if
the compiler doesn't optimize it, the C library has highly optimized
versions which isn't going to happen with our own implementation.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message