apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [PATCH] First pass at moving util_uri to apr-util...
Date Mon, 21 May 2001 03:28:15 GMT
On Sun, May 20, 2001 at 06:50:32PM -0700, Greg Stein wrote:
> When moving functions from one place to another (or whole files!), we can't
> make any changes during the move. It is practically impossible to see and
> review the changes made in transit.
> 
> The more ideal way to do this would be to simply "cvs add" util_uri.c as
> uri/apr_uti.c. *Then* to apply patches to make all the changes that you
> suggest. Similar for util_uri.h -> apr_uri.h.
> 
> I believe the first step would be to add those two files to APRUTIL, then
> change apr_uri.h to include a #ifdef NOT_READY_YET so the exports processing
> doesn't "see" the changes.
> 
> That would make the files available for applying patches.
> 
> We should be able to move the gen_uri_delims over directly.
> 
> How does that sound?

Good.  Now, if someone with commit access wants to do that, please do 
so.  =)

I don't have commit access - which is why I kind of need someone with
commit access to make this migration smoother (apr_uri isn't the
only one that needs to be switched over - but it is probably the most
involved).  I believe Ryan and Doug volunteered (?) to help out with 
this.  Maybe tomorrow they will be around and can provide some 
assistance on that end.  If anyone else thinks this is a worthy cause 
(and understands these patches), please feel free to step in!

There isn't too much more that I can do on my end except make the
patches as clean as possible.  Hopefully, I've done that.  If not,
let me know and I'll work on the patches some more...

Thanks.  -- justin


Mime
View raw message