apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: [PATCH] First-cut of APR_READWRITE locks...
Date Sat, 28 Apr 2001 20:50:46 GMT

A few nits:


> @@ -626,7 +626,7 @@
>      dnl BSD 4.4 originated 'q'.  Solaris is more popular and
>      dnl doesn't support 'q'.  Solaris wins.  Exceptions can
>      dnl go to the OS-dependent section.
> -    int64_t_fmt='#define APR_INT64_T_FMT "lld"'
> +    int64_t_fmt='#define APR_INT64_T_FMT "qd"'
>      int64_value="long long"
>      long_value="long long"
>  elif test "$ac_cv_sizeof_long_double" = "8"; then

Remind me why this change is necessary?  What about the comment above that
that gives a good reason not to use qd?



> Index: locks/os2/locks.c
> ===================================================================
> RCS file: /home/cvspublic/apr/locks/os2/locks.c,v
> retrieving revision 1.27
> diff -u -r1.27 locks.c
> --- locks/os2/locks.c	2001/03/19 12:43:25	1.27
> +++ locks/os2/locks.c	2001/04/28 20:06:44
> @@ -142,7 +142,10 @@
>      return APR_OS2_STATUS(rc);
>  }
>
> -
> +apr_status_t apr_lock_acquire_rw(apr_lock_t *lock, apr_readerwriter_e e)
> +{
> +    return APR_OS2_STATUS(APR_ENOTIMPL);
> +}
>
>  apr_status_t apr_lock_release(apr_lock_t *lock)
>  {

This should just be "return APR_ENOTIMPL;".  Only use APR_OS2_STATUS to
convert from an os-style error to an APR-style error code.

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Mime
View raw message