apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Marr <gr...@alum.wpi.edu>
Subject Re: Buckets code question
Date Wed, 11 Apr 2001 15:59:30 GMT
At 11:50 AM 04/11/2001, Cliff Woolley wrote:
>While this causes some very minor redundancy in the
>apr_bucket_foo_create() functions, it has several benefits:
>
>(1) both warnings and errors eliminated
>(2) the magical return is made explicit, which makes
>     apr_bucket_foo_create() easier to understand for someone not
>     familiar with apr_bucket_do_create()'s innards.

I agree.  Having macros that look like functions, but have return 
statements in them, is bad.  It also prevents those macros from being 
made into inline functions without changing all the places that call 
them.

-- 
Greg Marr
gregm@alum.wpi.edu
"We thought you were dead."
"I was, but I'm better now." - Sheridan, "The Summoning"


Mime
View raw message