apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jon Travis <jtra...@p00p.org>
Subject Re: [PATCH] socket family fetching
Date Mon, 30 Apr 2001 23:24:23 GMT
On Mon, Apr 30, 2001 at 05:58:30PM -0400, Jeff Trawick wrote:
> Jon Travis <jtravis@p00p.org> writes:
> 
> > I need a routine to fetch the socket family.  I could just refer
> > to the information in the sockaddr_t address length, but that is
> > rather hackish.  Anyway, here tis.  We should also probably be
> > moving towards making the sockaddr_t an opaque type, or at least
> > some of the members.
> 
> I think that the better place to look is addr->sa.sin.sin_family.
> Hopefully you should be able to return this as-is.
> 
> On first thought, the partial opaqueness makes sense (though I don't
> know how to do that neatly in C).  Thinking down the road, the number
> of accessor functions could get out of hand (similar to the
> apr_fileinfo_t issue).  I'm mostly happy with apps peering into the
> apr_sockaddr_t, though maybe we need to make it friendlier by adding
> (e.g.) a family field which starts out as APR_UNSPEC and is set once
> we know the family.

Just do like so:

(in apr_network_io.h)
typedef struct apr_sockaddr_priv_t apr_sockaddr_priv_t;
struct apr_sockaddr_t {
	apr_pool_t *pool;,
	...
	apr_sockaddr_priv_t *privdata;
};

Then define apr_sockaddr_priv_t in either a header local only to the 
subdirectories (network_io, etc.) or simply define the members in the 
actual C file that uses it.  

Poking about in the sockaddr_in is kinda fun and easy to do, but is really
going to let people shoot themselves fairly easily, I fear.

-- Jon


Mime
View raw message