apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [PATCH] distclean cleanups
Date Fri, 06 Apr 2001 15:00:36 GMT
On Fri, Apr 06, 2001 at 01:41:51AM -0700, Greg Stein wrote:
> apr-util/xml/expat/ is ASF-managed. We should patch it whenever and however
> we like. I'll cross-sync ours with the real Expat. At some point, our needs
> will precisely coincide with the real Expat CVS repository (they don't
> *yet*) and we can completely dump our copy. But until they coincide, we'll
> simply keep a tweaked copy in our repository.

Okay, that's fine - I wasn't sure what the policy was.

> Enough with the black hole already. You mentioned this once before. We all

I didn't mean it as a slight towards anyone - just comical.  Sorry for any 
offense.  I know you all are busy - I don't want to add to anyone's work
load here (especially this week).  In fact, I was hoping that I would
lessen others' load by submitting these patches.  Again, my apologies.

> The other day, I complained about Mike Abbott's "drive-by patching." Patches
> need a caretaker; dropping them on us and going away is invariably the wrong
> approach.

I don't intend to do that, but feedback (like this) is appreciated every
once in a while.  Thanks - I'm not asking for much...

> We discussed using "extraclean" consistently, everywhere. Apache has a
> "cvsclean" target, IIRC. Roy may have tossed it, though. The extraclean
> target is used by quite a few other software packages.

cvsclean isn't there right now.  I switched my patch to use extraclean.

> config.nice != config.status
> It should *not* be removed by a distclean. Very often, we will rebuild a
> "configure" and want to run it with the same options. config.status isn't
> correct since it corresponds to a different "configure". Thus, we have
> config.nice. And it needs to survive across a distclean.

I realized that - this is why I mentioned it.  But, Apache 1.3.x does
delete the config.status file - although it is a different name, config.nice
in Apache 2.0 is equivalent (IMHO) to config.status.  I thought I would
submit a patch that tries to follow what has been done before.  But, yes,
I agree - config.nice should not be deleted.

> exports.c could go into the EXTRACLEAN_TARGETS because it could (should?) be
> distributed with the tarball. It isn't going to change from one
> configuration to the next, and it is portable

Done - as I said, I wasn't sure where it should go.  I guess it needs to
be included with the tarball (it showed up on rse's diff).

> libtool needs to be removed from the EXTRACLEAN.

I knew something would slip by.  =-)  Thanks.

> The build/* files should NOT be in the top-level Makefile.in. build/ already
> has its own Makefile, with cleaning targets for a bunch of stuff.

I don't see the Makefile.in in the build directories.  Am I missing

Thanks.  -- justin

View raw message