apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject [PATCH] distclean cleanups
Date Fri, 06 Apr 2001 03:19:23 GMT
On Fri, Apr 06, 2001 at 03:05:57AM +0200, Ralf S. Engelschall wrote:
> 
> o If I unpack httpd-2_0_16-beta.tar.gz twice and in one copy
>   perform "./configure --enable-modules=most; make; make distclean"
>   the result is different from a fresh unpack:

These attached patches should be a step in the right direction for getting
distclean to work as expected.  Because these patches apply to different
repository, I attached them (I hope that is okay).  Patches for httpd-2.0,
apr, and apr-util.  I didn't touch expat because Greg or someone else knows 
that better than I - I could submit a patch for this as well, but this isn't
ASF stuff.  If he feels like cleaning it up, Greg could commit it into the 
real expat repository.

If someone likes these patches, they can commit them.  

My own comments before these patches disappear into the black hole:

The Makefile.in in httpd-2.0 had a lot of stale DISTCLEAN_TARGETS variables, 
so I tried to figure out what is still present in the repository.

.deps is removed by build/rules.mk for the distclean target already, so I 
guess the directory used for building the tarball was not clean (Ryan?).
I'd suggest adding a "dist" target that does the actual rolling of a
tarball (obviously not the tagging).  That way someone can easily
roll a similar tarball (with excluded files and stuff) from the end-user 
build system.  I don't know if Ryan has finalized the process for the
rolling of a tarball yet.  He's the RM...  =-)

I added a simple maintainer-clean target to build/rules.mk and related
MAINTAINERCLEAN_TARGETS, but the apr/apr-util Makefiles define 
EXTRACLEAN_TARGETS.  Shall we standardize this, or has this already been 
discussed?  Based on my interpretation, the GNU standards texinfo page 
suggests maintainer-clean.  apr defines EXTRACLEAN_TARGETS, but it doesn't 
seem to use them anywhere (could just be missing the reference).

Although I could see a case for keeping config.nice around even past
a distclean, these patches remove it.  I think you could leave config.nice, 
but I'm not sure what the accepted practice is.  Apache 1.3.x deleted the 
config.status (which is really what config.nice is), so that settles it for 
me right now.

I'm not sure of the usage of server/exports.c, but I just added it to
DISTCLEAN_TARGETS.  There seems to be a delete-exports target, but I haven't
taken the time to understand it.  I think it is regenerated somewhere, so
we should delete it when doing a distclean.

Most of the other stuff is fairly straightforward.  

Enjoy.  -- justin

Mime
View raw message