apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <ad...@rowe-clan.net>
Subject Re: cvs commit: apr/test sendfile.c
Date Sun, 01 Apr 2001 05:42:40 GMT
> trawick     01/03/31 14:37:13
> 
>   Modified:    test     sendfile.c
>   Log:
>   fix bad return code checking and a bad error message after
>   a call to apr_stat(); now it works on Win32
>   
>   Revision  Changes    Path
>   1.12      +2 -2      apr/test/sendfile.c
>   
>   Index: sendfile.c
>   ===================================================================
>   RCS file: /home/cvs/apr/test/sendfile.c,v
>   retrieving revision 1.11
>   retrieving revision 1.12
>   diff -u -r1.11 -r1.12
>   --- sendfile.c 2001/02/16 19:46:25 1.11
>   +++ sendfile.c 2001/03/31 22:37:13 1.12
>   @@ -189,8 +189,8 @@
>        }
>    
>        rv = apr_stat(&finfo, fname, APR_FINFO_NORM, p);
>   -    if (rv) {
>   -        fprintf(stderr, "apr_file_close()->%d/%s\n",
>   +    if (rv != APR_SUCCESS && rv != APR_INCOMPLETE) {
>   +        fprintf(stderr, "apr_stat()->%d/%s\n",

Do we even need the whole shebang here, or is a subset of useful info
acceptable?  I don't know that we want to even ask the system to do
the whole enchilada


Mime
View raw message