Return-Path: 
 <dev-return-1316-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 68467 invoked by uid 500); 19 Feb 2001 01:57:30 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Subscribe: <mailto:dev-subscribe@apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 68450 invoked from network); 19 Feb 2001 01:57:28 -0000
From: Cliff Woolley <cliffwoolley@yahoo.com>
To: dev@apr.apache.org, new-httpd@apache.org
MMDF-Warning: Parse error in original version of preceding line at
 mail.virginia.edu
Subject: RE: cvs commit: apr-util/include apr_buckets.h
Date: Sun, 18 Feb 2001 20:56:07 -0500
Message-ID: <NEBBKBPPOLLGMBILHACFOEFCCBAA.cliffwoolley@yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0)
Importance: Normal
In-Reply-To: <20010219014257.65610.qmail@apache.org>
X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2615.200
X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N

> -----Original Message-----
> jwoolley    01/02/18 17:42:57
>
>   Modified:    include  apr_buckets.h
>   Log:
>   Add apr_bucket_delete(), which is a wrapper macro around bucket removal/
>   destruction.  Useful for decreasing code verbosity.

I decided to go the route of adding a third macro (apr_bucket_delete()) instead
of overloading apr_bucket_destroy().  It's nice to have access to the "atomic"
removal and destruction functions if you really need them, and also I tend to
think of destruction as "just get rid of the damned thing, don't be nice about
it".  "delete" is the nice way to "destroy".  <shrug>

Anyway, all sequences like this:

    APR_BUCKET_REMOVE(e);
    apr_bucket_destroy(e);

can now become:

    apr_bucket_delete(e);

I'll work on a cleanup patch for Apache.  (I've also got that
APR_BUCKET_INSERT_BEFORE(a,b) cleanup patch that's in the works.)


--Cliff

---------------------------------------------------
    Cliff Woolley
    cliffwoolley@yahoo.com
    804-244-8615
    Charlottesville, VA