apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: [PATCH] a somewhat different approach to the iconv() issue
Date Thu, 08 Feb 2001 01:32:05 GMT
"Roy T. Fielding" <fielding@ebuilt.com> writes:

> > . we *know* that versions of glibc < 2.2 have "const char **"
> >   instead of "char **" so make that work without any hints.m4
> >   stuff (which would have to look at the glibc version)
> 
> Why not check for GCC and simply add -Werror to the compile?

excellent...

...
> I think the final patch should remove the first cast of inbufptr
> that I added in my initial "fix".

You're talking about this I presume...

  @@ -285,7 +285,7 @@
       size_t translated;
   
       if (convset->ich != (iconv_t)-1) {
  -        char *inbufptr = inbuf;
  +        char *inbufptr = (char *)inbuf;
           char *outbufptr = outbuf;
           
           translated = iconv(convset->ich, &inbufptr, 
  
Thanks,

-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message