apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: cvs commit: apr-util/buckets apr_brigade.c
Date Wed, 28 Feb 2001 16:04:59 GMT
On Wed, 28 Feb 2001, Cliff Woolley wrote:

> On 28 Feb 2001 rbb@apache.org wrote:
>
> >                buf = malloc(APR_BUCKET_BUFF_SIZE);
> >                b = apr_bucket_heap_create(buf, APR_BUCKET_BUFF_SIZE, 0, NULL);
>
> On a side note, we currently have two macros that do almost the same
> thing: APR_BUCKET_BUFF_SIZE (=9000) which determines the size of the
> buffer for brigade buffering and HUGE_STRING_LEN (=8192) which determines
> the size of the buffer for reading from files, pipes, and sockets.  Can we
> standardize on one of the two?  Personally, I prefer the name of
> APR_BUCKET_BUFF_SIZE, but kind of like the 8KB size of the other.

I like making APR_BUCKET_BUFF_SIZE == 8192 and removing the other.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message