apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: apr_threads.m4 patch for Solaris
Date Wed, 21 Feb 2001 21:06:11 GMT

This patch looks good, and I'll commit it tomorrow morning unless somebody
beats me to it.  (I'm re-installing my laptop, so I don't have access to
my apache trees right now).  I agree 100% that we should THREAD_CPPFLAGS
throughout apr_hints.m4, could you please provide a patch that does that?
If not, I'll add that to the patch before I commit tomorrow.

Thanks a lot for the patch, keep 'em coming.  :-)

Ryan

On Wed, 21 Feb 2001, Justin Erenkrantz wrote:

> Attached is a simple patch to include the result of THREADS_CPPFLAGS
> when checking for sigwait.  On Solaris, if _POSIX_PTHREAD_SEMANTICS
> is not defined, thn sigwait exists with only one argument.  However, if
> _POSIX_PTHREAD_SEMANTICS is defined, sigwait exists with two arguments.
>
> apr_hints.m4 correctly adds _POSIX_PTHREAD_SEMANTICS to THREAD_CPPFLAGS
> for Solaris, but apr_threads.m4 doesn't use THREAD_CPPFLAGS.  I'd suggest
> using this for the entire apr_threads.m4, but this isn't my call - I'll
> just submit a patch for what is obviously broken.
>
> I've tested this on Solaris/Intel and Solaris/Sparc.  It also doesn't
> break my Linux/Intel build.  It seems obvious enough that it doesn't
> require more testing.  =-)
>
> HTH,
> Justin Erenkrantz
> jerenkrantz@ebuilt.com
>
> Index: apr_threads.m4
> ===================================================================
> RCS file: /home/cvspublic/apr/build/apr_threads.m4,v
> retrieving revision 1.4
> diff -u -r1.4 apr_threads.m4
> --- apr_threads.m4	2001/02/21 11:35:15	1.4
> +++ apr_threads.m4	2001/02/22 04:51:33
> @@ -158,6 +158,8 @@
>
>  AC_DEFUN(APR_CHECK_SIGWAIT_ONE_ARG,[
>    AC_CACHE_CHECK(whether sigwait takes one argument,ac_cv_sigwait_one_arg,[
> +  ac_save="$CPPFLAGS"
> +  CPPFLAGS="$CPPFLAGS $THREAD_CPPFLAGS"
>    AC_TRY_COMPILE([
>  #ifdef __NETBSD__
>      /* When using the unproven-pthreads package, we need to pull in this
> @@ -179,4 +181,5 @@
>    if test "$ac_cv_sigwait_one_arg" = "yes"; then
>      AC_DEFINE(SIGWAIT_TAKES_ONE_ARG,1,[ ])
>    fi
> +  CPPFLAGS="$ac_save"
>  ])
>
>


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message