apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: brigade/bucket insertion macros
Date Tue, 13 Feb 2001 14:55:01 GMT
> --- rbb@covalent.net wrote:
> > > That allows the snippet above to collapse to this:
> > > 
> > >     APR_BRIGADE_INSERT_HEAD(bb, apr_bucket_file_create(fd, 0,
> > > r->finfo.size));
> > >     APR_BRIGADE_INSERT_TAIL(bb, apr_bucket_eos_create());
> > > 
> > > AFAICT, the cost is minimal, and the code is much cleaner looking.  Since
> > > these sequences of bucket creation/insertion can be arbitrarily long, this
> > > is a Good Thing IMHO.  Thoughts?
> > 
> > ++1.  If you provide a full patch, I will commit it immediately.
> 
> I did, didn't I?  It should have been at the bottom of that message.  Or do you mean
a
> full patch to mass-cleanup all callers of the macros throughout Apache?

I meant the latter.  I can apply what you already sent in about an hour, I
need to get to the office soon.  All that's left is the rest of the
cleanup.  :-)

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message