apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: cvs commit: apr-util/include apr_buckets.h
Date Thu, 01 Mar 2001 02:27:06 GMT
On Wed, 28 Feb 2001, Greg Stein wrote:

> The use of the "f" local variable is pointless in the above code. "data" is
> valid throughout the function. The aliasing of "data" to "f" simply makes
> the connection between destroy() and free() less obvious.
>
> In all of these destroy() functions, the local should simply be tossed, and
> "data" used directly.

I'd thought about doing that... but ended up just leaving them in.  In
hindsight, I should have nuked the things, and I never would have
forgotten to initialize the one in mmap_read() that Jeff had to fix
earlier today.

I'll get rid of them.

--Cliff


Mime
View raw message