apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject apr_threads.m4 patch for Solaris
Date Thu, 22 Feb 2001 05:03:43 GMT
Attached is a simple patch to include the result of THREADS_CPPFLAGS
when checking for sigwait.  On Solaris, if _POSIX_PTHREAD_SEMANTICS
is not defined, thn sigwait exists with only one argument.  However, if
_POSIX_PTHREAD_SEMANTICS is defined, sigwait exists with two arguments.

apr_hints.m4 correctly adds _POSIX_PTHREAD_SEMANTICS to THREAD_CPPFLAGS
for Solaris, but apr_threads.m4 doesn't use THREAD_CPPFLAGS.  I'd suggest
using this for the entire apr_threads.m4, but this isn't my call - I'll 
just submit a patch for what is obviously broken.

I've tested this on Solaris/Intel and Solaris/Sparc.  It also doesn't
break my Linux/Intel build.  It seems obvious enough that it doesn't
require more testing.  =-)

HTH,
Justin Erenkrantz
jerenkrantz@ebuilt.com

Index: apr_threads.m4
===================================================================
RCS file: /home/cvspublic/apr/build/apr_threads.m4,v
retrieving revision 1.4
diff -u -r1.4 apr_threads.m4
--- apr_threads.m4	2001/02/21 11:35:15	1.4
+++ apr_threads.m4	2001/02/22 04:51:33
@@ -158,6 +158,8 @@
 
 AC_DEFUN(APR_CHECK_SIGWAIT_ONE_ARG,[
   AC_CACHE_CHECK(whether sigwait takes one argument,ac_cv_sigwait_one_arg,[
+  ac_save="$CPPFLAGS"
+  CPPFLAGS="$CPPFLAGS $THREAD_CPPFLAGS"
   AC_TRY_COMPILE([
 #ifdef __NETBSD__
     /* When using the unproven-pthreads package, we need to pull in this
@@ -179,4 +181,5 @@
   if test "$ac_cv_sigwait_one_arg" = "yes"; then
     AC_DEFINE(SIGWAIT_TAKES_ONE_ARG,1,[ ])
   fi
+  CPPFLAGS="$ac_save"
 ])                                                                              


Mime
View raw message