apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: docco problem (was RE: Chunk filter problem?)
Date Wed, 14 Feb 2001 00:22:43 GMT
On Tue, Feb 13, 2001 at 01:25:31PM -0500, Cliff Woolley wrote:
> 
> > -----Original Message-----
> > Okay, I'm not 100% sure on this, but I think I spotted a problem in the
> > chunk filter such that two immortal buckets are getting inserted AFTER the
> > EOS bucket by means of transposed parameters to the
> > APR_BUCKET_INSERT_BEFORE macro.
> 
> Okay, I had it the wrong way around, thankfully.  It's the documentation
> that's got it wrong, not the chunk filter.  So nix the chunk filter patch,
> as it's incorrect.  Instead, we just need to change the docco in
> apr_buckets.h in APR-UTIL to reflect reality:

Didn't you say that mod_include used them the other direction? Does this
mean that mod_include is now wrong?

> It'd be really nice if the ring macros were documented, as that would have
> cleared up this confusion pretty quickly (as it was, I had to trace through
> the ring macros on a whiteboard to make absolutely sure of which way around
> they were supposed to go).  I don't suppose anyone would object if I
> documented them?  =-)

Heh... no :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message