apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/include apr_lib.h
Date Mon, 12 Feb 2001 02:05:14 GMT
On Sun, Feb 11, 2001 at 11:31:04PM -0000, wrowe@apache.org wrote:
> wrowe       01/02/11 15:31:04
> 
>   Modified:    .        CHANGES
>                passwd   apr_getpass.c
>                include  apr_lib.h
>   Log:
>     result(?)  What result?  Stop mauling the size_t arg and overwrite the
>     system buffer before returning from apr_password_get, and clean up doc.
>...
>   --- apr_lib.h	2001/02/11 00:12:11	1.51
>   +++ apr_lib.h	2001/02/11 23:31:04	1.52
>   @@ -220,12 +220,12 @@
>    /**
>     * Display a prompt and read in the password from stdin.
>     * @param prompt The prompt to display
>   - * @param pwbuf Where to store the password
>   - * @param bufsize The length of the password string.
>   + * @param pwbuf Buffer to store the password
>   + * @param bufsize The length of the password buffer.
>     * @deffunc apr_status_t apr_password_get(const char *prompt, char *pwbuf, size_t
*bufsize)
>     */
>    APR_DECLARE(apr_status_t) apr_password_get(const char *prompt, char *pwbuf, 
>   -                                      size_t *bufsize);
>   +                                           size_t *bufsize);

Um... couldn't that bufsize just be an apr_size_t rather than "size_t *" ??
If you aren't going to return a value, then drop the indirection, right?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message