Return-Path: Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Delivered-To: mailing list dev@apr.apache.org Received: (qmail 5381 invoked from network); 29 Jan 2001 13:07:44 -0000 Received: from mail0.bna.bellsouth.net (205.152.150.12) by h31.sny.collab.net with SMTP; 29 Jan 2001 13:07:44 -0000 Received: from adsl-77-241-65.rdu.bellsouth.net (adsl-77-241-65.rdu.bellsouth.net [216.77.241.65]) by mail0.bna.bellsouth.net (3.3.5alt/0.75.2) with ESMTP id IAA25208 for ; Mon, 29 Jan 2001 08:07:44 -0500 (EST) Received: (from trawick@localhost) by adsl-77-241-65.rdu.bellsouth.net (8.9.3/8.8.7) id IAA01514; Mon, 29 Jan 2001 08:08:27 -0500 X-Authentication-Warning: adsl-77-241-65.rdu.bellsouth.net: trawick set sender to trawickj@bellsouth.net using -f Sender: trawick@bellsouth.net To: dev@apr.apache.org Subject: Re: cvs commit: apr/include apr_xlate.h References: <20010128174904.A803@waka.ebuilt.net> From: Jeff Trawick Date: 29 Jan 2001 08:08:27 -0500 In-Reply-To: "Roy T. Fielding"'s message of "Sun, 28 Jan 2001 17:49:04 -0500" Message-ID: Lines: 30 User-Agent: Gnus/5.0807 (Gnus v5.8.7) Emacs/20.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N "Roy T. Fielding" writes: > However, the code > will work fine regardless of the warning, so it probably isn't > worth the effort to support no warnings on anything but the latest > gcc. you mean the latest glibc Previously, we had a warning on OS/390 and Tru64 (and I guess the level of glibc which comes with RH 7) because they had no const, and a clean compile everywhere else. I left it alone since their iconv() did not match the de facto standard and I didn't want to put in a cast that people on normal systems would not understand. I certainly didn't want a cast which would cause warnings. I had no qualms having the warning on Tru64 and OS/390 (not that many people build it on these platforms and it kept the code simpler). Now, most users (I'm guessing, but it seems like a safe guess) will see a warning, so something needs to be done. I'll look into using a different cast trick (or autoconf test) which will avoid the warning on all platforms. As long as there is a reasonable comment in the code I suspect people will live it alone (do you hear that Greg? :) ) Have fun... -- Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site: http://www.geocities.com/SiliconValley/Park/9289/ Born in Roswell... married an alien...