Return-Path: Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Delivered-To: mailing list dev@apr.apache.org Received: (qmail 57765 invoked from network); 5 Jan 2001 18:43:49 -0000 Received: from i.meepzor.com (HELO Mail.MeepZor.Com) (root@204.146.167.214) by h31.sny.collab.net with SMTP; 5 Jan 2001 18:43:49 -0000 Received: from allane3 ([206.199.198.4]) by Mail.MeepZor.Com (8.8.7/8.8.7) with SMTP id NAA13607 for ; Fri, 5 Jan 2001 13:47:58 -0500 From: "Allan Edwards" To: Subject: RE: cvs commit: apr/lib apr_pools.c Date: Fri, 5 Jan 2001 13:39:31 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) In-Reply-To: <20010102013305.52433.qmail@daedelus.apache.org> X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700 Importance: Normal X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N > -----Original Message----- > From: rbb@apache.org [mailto:rbb@apache.org] > Sent: Monday, January 01, 2001 8:33 PM > To: apr-cvs@apache.org > Subject: cvs commit: apr/lib apr_pools.c > > > rbb 01/01/01 17:33:05 > > Modified: . CHANGES > lib apr_pools.c > Log: > Remove the ability to allocate out of a NULL pool. This was always a bad > idea, because it opened up memory leaks. It is very likely that this will > expose some seg faults This is indeed true, now that Windows httpd-2.0 is building again it has exposed a couple of problems. In ap_is_rdirectory, apr_lstat is passed a NULL pool pointer which eventually causes apr_palloc to segfault. I assume the correct fix is to pass in a pool parameter to ap_is_rdirectory. Similar situation seems to exist with apr_stat being passed a NULL pool by ap_is_directory. I'll go ahead and fix these. Allan