Return-Path: <cmpilato@newton.collab.net>
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 1910 invoked from network); 29 Jan 2001 20:10:07 -0000
Received: from 24-148-31-193.na.21stcentury.net (HELO newton.collab.net)
 (24.148.31.193)
  by h31.sny.collab.net with SMTP; 29 Jan 2001 20:10:07 -0000
Received: (from cmpilato@localhost)
	by newton.collab.net (8.9.3/8.9.3) id OAA40745;
	Mon, 29 Jan 2001 14:15:14 -0600 (CST)
	(envelope-from cmpilato)
Sender: cmpilato@newton.collab.net
To: dev@apr.apache.org
Cc: apr-cvs@apache.org
Subject: Re: cvs commit: apr/file_io/win32 filestat.c
References: <20010129171024.29232.qmail@apache.org>
From: cmpilato@collab.net
Reply-To: cmpilato@collab.net
Date: 29 Jan 2001 14:15:13 -0600
In-Reply-To: stoddard@apache.org's message of "29 Jan 2001 17:10:24 -0000"
Message-ID: <84itmyt8ry.fsf@newton.collab.net>
Lines: 60
X-Mailer: Gnus v5.7/Emacs 20.6
X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N

Hey, all.  This fix also fixed a build problem I was having in Win98,
but I'm worried that the fix might be skirting a bigger issue.  Code
exists in apr_private.h that "turns off" the use of Windows' GDI
library (by #define'ing NOGDI) among other things.  The recent
inclusion of <aclapi.h>, on Win98 platforms, eventually results in
<wtypes.h> being included, part of which depends on the GDI headers
being available.  I do NOT expect this to happen on WinNT, but as I
don't have an NT box here, I can't verify that.

At any rate, the REASON the fix below helped is because the GDI stuff
wasn't opted out until the following conclusion of apr_private.h.  I
general get concerned when the order of header inclusion means the
difference between a successful and a failed build.

Can someone provide some insight as to why APR explicitly attempts to
bar inclusion of the GDI, USER, and 3 other classes of header files in
apr_private.h?

Thanks.

--Mike

stoddard@apache.org writes:

> stoddard    01/01/29 09:10:22
> 
>   Modified:    file_io/win32 filestat.c
>   Log:
>   This fixes a funky compile problem for me.
>   
>   Revision  Changes    Path
>   1.44      +1 -1      apr/file_io/win32/filestat.c
>   
>   Index: filestat.c
>   ===================================================================
>   RCS file: /home/cvs/apr/file_io/win32/filestat.c,v
>   retrieving revision 1.43
>   retrieving revision 1.44
>   diff -u -r1.43 -r1.44
>   --- filestat.c	2001/01/29 06:21:40	1.43
>   +++ filestat.c	2001/01/29 17:10:19	1.44
>   @@ -52,6 +52,7 @@
>     * <http://www.apache.org/>.
>     */
>    
>   +#include <aclapi.h>
>    #include "apr_private.h"
>    #include "win32/fileio.h"
>    #include "apr_file_io.h"
>   @@ -62,7 +63,6 @@
>    #include <sys/stat.h>
>    #include "atime.h"
>    #include "misc.h"
>   -#include <aclapi.h>
>    
>    static apr_status_t free_localheap(void *heap) {
>        LocalFree(heap);
>   
>   
>