Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Message-ID: <3A74188E.1F61E6B1@algroup.co.uk>
Date: Sun, 28 Jan 2001 13:03:10 +0000
From: Ben Laurie <ben@algroup.co.uk>
MIME-Version: 1.0
To: dev@apr.apache.org
CC: apr-cvs@apache.org
Subject: Re: cvs commit: apr/include apr_xlate.h
References: <20010128113355.4872.qmail@apache.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

fielding@apache.org wrote:
> 
> fielding    01/01/28 03:33:55
> 
>   Modified:    i18n/unix xlate.c
>                include  apr_xlate.h
>   Log:
>   Revert last change and solve warning by explicit cast.  The need would
>   have been obvious if dependencies were in the Makefile.
> 
>   Revision  Changes    Path
>   1.18      +2 -2      apr/i18n/unix/xlate.c
> 
>   Index: xlate.c
>   ===================================================================
>   RCS file: /home/cvs/apr/i18n/unix/xlate.c,v
>   retrieving revision 1.17
>   retrieving revision 1.18
>   diff -u -r1.17 -r1.18
>   --- xlate.c   2001/01/28 09:50:00     1.17
>   +++ xlate.c   2001/01/28 11:33:52     1.18
>   @@ -276,7 +276,7 @@
>        return APR_SUCCESS;
>    }
> 
>   -apr_status_t apr_xlate_conv_buffer(apr_xlate_t *convset, char *inbuf,
>   +apr_status_t apr_xlate_conv_buffer(apr_xlate_t *convset, const char *inbuf,
>                                       apr_size_t *inbytes_left, char *outbuf,
>                                       apr_size_t *outbytes_left)
>    {
>   @@ -285,7 +285,7 @@
>        size_t translated;
> 
>        if (convset->ich != (iconv_t)-1) {
>   -        char *inbufptr = inbuf;
>   +        char *inbufptr = (char *)inbuf;
>            char *outbufptr = outbuf;

Eh? Why are you casting away the const???

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff