Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Date: Tue, 23 Jan 2001 14:47:45 -0800
From: Greg Stein <gstein@lyra.org>
To: dev@subversion.tigris.org
Cc: dev@apr.apache.org
Subject: Re: APR Changes to apr_stat and apr_getfileinfo
Message-ID: <20010123144745.B704@lyra.org>
Mail-Followup-To: dev@subversion.tigris.org, dev@apr.apache.org
References: <20010122114105.A15422@pilch-bisson.net>
 <86vgr69kzz.fsf@newton.collab.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <86vgr69kzz.fsf@newton.collab.net>;
 from sussman@newton.collab.net on Tue, Jan 23, 2001 at 12:33:20PM -0600

On Tue, Jan 23, 2001 at 12:33:20PM -0600, Ben Collins-Sussman wrote:
> Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
> 
> > I did a CVS update today, and noticed that the APR interface has changed
> > for apr_stat and apr_getfileinfo to accept an argument for what info
> > should be returned.  I changed the three files to retrieve the normal
> > information you would expect from a unix stat call.  Here is the diff:
> 
> Just reviewed your patch, Kevin, and it looks great.  You've fixed all
> the (recently) broken apr_stat() calls we were making.  I'll apply the
> patch very soon.
> 
> However, the tree still won't build right now because apr_item_t just
> vanished from APR, and libsvn_subr/keysort.c was depending heavily on
> it.  I need to fix this problem as well when I commit.

apr_item_t was part of the "btable" interface which has been removed. I'd
suggest that keysort define its own structure rather than rely on an APR
structure that "happens" to match its needs.

Note that it isn't even following the semantics of the old apr_item_t type.
It is using ((key, size), data) -- associating the size with the key. But
the docs on apr_item_t associate the size with the data instead.

apr_item_t shouldn't have been used, so it seems "right" to change keysort.c
to use an SVN structure.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/