Return-Path: Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Delivered-To: mailing list dev@apr.apache.org Received: (qmail 33203 invoked from network); 7 Jan 2001 00:25:17 -0000 Received: from kurgan.lyra.org (198.144.203.198) by h31.sny.collab.net with SMTP; 7 Jan 2001 00:25:17 -0000 Received: (from gstein@localhost) by kurgan.lyra.org (8.9.3/8.9.3) id QAA29322 for dev@apr.apache.org; Sat, 6 Jan 2001 16:25:02 -0800 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Sat, 6 Jan 2001 16:25:02 -0800 From: Greg Stein To: dev@apr.apache.org Subject: Re: cvs commit: apr/network_io/unix sendrecv.c Message-ID: <20010106162502.H17220@lyra.org> Mail-Followup-To: dev@apr.apache.org References: <20010107000007.15984.qmail@apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20010107000007.15984.qmail@apache.org>; from rbb@apache.org on Sun, Jan 07, 2001 at 12:00:07AM -0000 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On Sun, Jan 07, 2001 at 12:00:07AM -0000, rbb@apache.org wrote: > rbb 01/01/06 16:00:07 > > Modified: . CHANGES > network_io/unix sendrecv.c > Log: > We don't actually use os_cork or os_uncork on FreeBSD, so we shouldn't > define them. This removes some warnings. >... > --- sendrecv.c 2001/01/04 22:02:34 1.55 > +++ sendrecv.c 2001/01/07 00:00:07 1.56 > @@ -198,7 +198,7 @@ > * need to move these to the top... > */ > > -#if APR_HAVE_CORKABLE_TCP > +#if APR_HAVE_CORKABLE_TCP && !defined(__FreeBSD__) > > /* TCP_CORK & TCP_NOPUSH keep us from sending partial frames when we > * shouldn't. They are however, mutually exclusive with TCP_NODELAY I don't understand this. Why don't we just /not/ define APR_HAVE_CORKABLE_TCP on the FreeBSD boxes? (in the ./configure script) That seems more appropriate than adding platform-specific checks into the code. Cheers, -g -- Greg Stein, http://www.lyra.org/