Return-Path: Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Delivered-To: mailing list dev@apr.apache.org Received: (qmail 35364 invoked from network); 2 Jan 2001 06:36:17 -0000 Received: from nat.ebuilt.net (HELO mana.ebuilt.com) (209.216.43.20) by h31.sny.collab.net with SMTP; 2 Jan 2001 06:36:17 -0000 Received: (from fielding@localhost) by mana.ebuilt.com (8.9.3/8.9.3/SuSE Linux 8.9.3-0.1) id WAA00535; Mon, 1 Jan 2001 22:40:39 -0800 Date: Mon, 1 Jan 2001 22:40:39 -0800 From: "Roy T. Fielding" To: rbb@covalent.net Cc: dev@apr.apache.org Subject: Re: cvs commit: apr/include apr_general.h Message-ID: <20010101224039.A500@mana.ebuilt.com> References: <20010101191428.H10567@lyra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.9i In-Reply-To: ; from rbb@covalent.net on Mon, Jan 01, 2001 at 08:40:26PM -0800 X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N > > > > Then write apr_file_get_pool(). Not a cast and an assumption. > > > > > > That also means that we have to write apr_socket_get_pool and > > > apr_lock_get_pool and apr_mmap_get_pool, etc. > > > > Yup. > > That is ugly and just plain wrong. It is also standard design practice for use of incomplete types. You should be following it or not using incomplete types. I personally find it ugly and don't use incomplete types. > If I understand your problem with this, you are afraid that somebody will > use this macro on a variable that is either not an APR variable, or is an > APR type but is not one of the incomplete types. Well, this can be fixed > multiple ways. Just require that every APR structure has a pool at the > beginning of the structure, whether it is complete or not. I would argue that none of the APR types should have a pool, but I don't have that much time on my hands. ....Roy