From ben@algroup.co.uk  Sat Jan 27 20:04:05 2001
Return-Path: <ben@algroup.co.uk>
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 35852 invoked from network); 27 Jan 2001 20:04:05 -0000
Received: from sockittome.aldigital.co.uk (HELO freeby.ben.algroup.co.uk) (194.128.162.252)
  by h31.sny.collab.net with SMTP; 27 Jan 2001 20:04:05 -0000
Received: from algroup.co.uk (wiese.ben.algroup.co.uk [193.133.15.150]) by freeby.ben.algroup.co.uk (8.6.12/8.6.12) with ESMTP id UAA04031; Sat, 27 Jan 2001 20:04:04 GMT
Message-ID: <3A73299D.A18EBD8D@algroup.co.uk>
Date: Sat, 27 Jan 2001 20:03:41 +0000
From: Ben Laurie <ben@algroup.co.uk>
X-Mailer: Mozilla 4.76 [en] (Windows NT 5.0; U)
X-Accept-Language: en
MIME-Version: 1.0
To: dev@apr.apache.org
CC: apr-util-cvs@apache.org
Subject: Re: cvs commit: apr-util/hooks apr_hooks.c
References: <20010127190329.88524.qmail@apache.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N

wrowe@apache.org wrote:
> 
> wrowe       01/01/27 11:03:29
> 
>   Modified:    include  apr_optional.h
>                hooks    apr_hooks.c
>   Log:
>     Not sure what all the private stuff is doing in the header... but heck,
>     this makes it all compile on win32.

See below...

> 
>   Revision  Changes    Path
>   1.2       +5 -3      apr-util/include/apr_optional.h
> 
>   Index: apr_optional.h
>   ===================================================================
>   RCS file: /home/cvs/apr-util/include/apr_optional.h,v
>   retrieving revision 1.1
>   retrieving revision 1.2
>   diff -u -r1.1 -r1.2
>   --- apr_optional.h    2001/01/27 17:50:49     1.1
>   +++ apr_optional.h    2001/01/27 19:03:28     1.2
>   @@ -72,8 +72,10 @@
>    #define APR_DECLARE_OPTIONAL_FN(ret,name,args) \
>    typedef ret APR_OPTIONAL_FN_TYPE(name) args;
> 
>   -/* Private function! DO NOT USE! */
>   -void apr_register_optional_fn(const char *szName,void (*pfn)(void));
>   +/* XXX: This doesn't belong here, then!
>   + * Private function! DO NOT USE!
>   + */
>   +APU_DECLARE_NONSTD(void) apr_register_optional_fn(const char *szName,void (*pfn)(void));

It has to be here, because...

>    /**
>     * Register an optional function. This can be later retrieved, type-safely, by
>   @@ -85,7 +87,7 @@
>         ((void (*)(const char *,APR_OPTIONAL_FN_TYPE(name) *))&apr_register_optional_fn)(#name,name)

...it is used here. The point is, you shouldn't use it directly.
Similarly for the other one.

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff