From dreid@jetnet.co.uk Thu Jan 11 21:49:32 2001 Return-Path: Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Delivered-To: mailing list dev@apr.apache.org Received: (qmail 44740 invoked from network); 11 Jan 2001 21:49:32 -0000 Received: from www.jetnet.co.uk (root@62.172.71.4) by h31.sny.collab.net with SMTP; 11 Jan 2001 21:49:32 -0000 Received: from VAIO (ppp96.dialin.co.uk [194.73.252.96]) (authenticated) by www.jetnet.co.uk (8.11.1/8.11.1) with ESMTP id f0BLnVs08547; Thu, 11 Jan 2001 21:49:31 GMT Message-ID: <044301c07c18$334d09c0$42fc49c2@VAIO> From: "David Reid" To: , "Jeff Trawick" References: <200101111436.JAA15451@adsl-77-241-65.rdu.bellsouth.net><20010111121502.J4640@lyra.org> <03f901c07c11$7c2aec90$42fc49c2@VAIO> Subject: Re: FreeBSD version check for thread-safe sendfile Date: Thu, 11 Jan 2001 21:47:30 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2919.6700 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700 X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N Well, that sounds reasonable... No objections from me. +1 david ----- Original Message ----- From: "Jeff Trawick" To: Sent: Thursday, January 11, 2001 9:12 PM Subject: Re: FreeBSD version check for thread-safe sendfile > "David Reid" writes: > > > How many places are we going to run into dependencies on version number for > > FreeBSD? I think we have 2, maybe 3 already and it's likely to grow. I > > think we need to do this a different way. > > > > Why don't we add a check in the early portion of configure.in that looks for > > freebsd, if it's found determines the version number and sets it as a > > variable such as FBSD_VERSION. This should probably be of the format we're > > already using, i.e. 34 for 3.4.x and 41 for 4.1.x and so on. I mean so far > > we're only interested if we have greater than a particular version and I can > > see that continuing. > > If there is 3.4.x, then perhaps it should be 340 for 3.4, 341 for > 3.4.1, etc. > > The version could be set to > > uname -r | sed -e 's/\(.\)\.\(.\)\.\(.\).*/\1\2\3/' | sed -e 's/\(.\)\.\(.\)\-.*/\1\20/' > > yielding 341 for 3.4.1-RELEASE and 340 for 3.4-RELEASE. > > Why limit the variable to FreeBSD? We'll have (or already have) > similar checks on other platforms. Make the variable name more > generic. > > -- > Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site: > http://www.geocities.com/SiliconValley/Park/9289/ > Born in Roswell... married an alien... >