apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: apr/tables apr_hash.c
Date Tue, 16 Jan 2001 18:56:18 GMT
Greg Stein <gstein@lyra.org> writes:

> On Tue, Jan 16, 2001 at 12:59:04PM -0500, Jeff Trawick wrote:
> > gstein@apache.org writes:
> >...
> > >    /**
> > >   - * Get the number of keys in the hash table.
> > >   + * Get the number of key/value pairs in the hash table.
> > >     * @param ht The hash table
> > >   - * @param count Return pointer for the number of keys
> > >   + * @return The number of key/value pairs in the hash table.
> > >     * @deffunc void apr_hash_count(apr_hash_t *ht, apr_size_t *count);
> > >     */
> > >   -APR_DECLARE(void) apr_hash_count(apr_hash_t *ht, apr_size_t *count);
> > >   +APR_DECLARE(apr_size_t) apr_hash_count(apr_hash_t *ht);
> > 
> > silly question: why not int or apr_int32_t instead of apr_size_t?
> 
> apr_size_t is the internal type. change that, and you can change the return
> type :-)

okay, just checking...  maybe I'll do just that :)

(IMHO, a sane API is more important than matching internal type,
though it seems that both are easy to accomplish in this case)

-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message