apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: Two small patches
Date Tue, 23 Jan 2001 14:55:58 GMT

Kevin, I'll try to commit these today.  Both look very good.  Thanks for
making them two distinct patches, it would have really made my job tougher
if they had been one patch.

Ryan

On Tue, 23 Jan 2001, Kevin Pilch-Bisson wrote:

> Hi all,
> 
> I have recently been contributing to the subversion project, and one of
> the things I am looking at is the build.  I noticed that APR would not
> do a build from a different directory properly and came up with this
> small patch to configure.in to make it work.  The second patch is for
> file_io/unix/dir.c which was using a `dirent *' where it needed a `struct
> dirent *'.  Hope these help.  I did them as two different patches since
> the two problems were so unrelated.
> 
> Modified: configure.in
> Log: Changed top_builddir to use $abs_builddir instead of $abs_srcdir
> 
> Revision    Changes Path
> 1.212       1       configure.in
> 
> Index: configure.in
> ===================================================================
> RCS file: /home/cvspublic/apr/configure.in,v
> retrieving revision 1.212
> diff -u -p -r1.212 configure.in
> --- configure.in	2001/01/23 06:16:29	1.212
> +++ configure.in	2001/01/23 14:39:43
> @@ -23,7 +23,7 @@ abs_srcdir=`(cd $srcdir && pwd)`
>  abs_builddir=`pwd`
>  
>  dnl Libtool needs this symbol
> -top_builddir="$abs_srcdir"
> +top_builddir="$abs_builddir"
>  AC_SUBST(top_builddir)
>  
>  dnl Get location of helpers directory
> 
> 
> Modified: file_io/unix/dir.c
> Log: Changed `dirent *' to `struct dirent *'
> 
> Revision    Changes Path
> 1.45        1       file_io/unix/dir.c
> 
> Index: file_io/unix/dir.c
> ===================================================================
> RCS file: /home/cvspublic/apr/file_io/unix/dir.c,v
> retrieving revision 1.45
> diff -u -p -r1.45 dir.c
> --- file_io/unix/dir.c	2001/01/23 06:16:48	1.45
> +++ file_io/unix/dir.c	2001/01/23 14:40:06
> @@ -115,7 +115,7 @@ apr_status_t apr_dir_read(apr_finfo_t *f
>      apr_status_t ret = 0;
>  #if APR_HAS_THREADS && defined(_POSIX_THREAD_SAFE_FUNCTIONS) \
>      && !defined(READDIR_IS_THREAD_SAFE)
> -    dirent *retent;
> +    struct dirent *retent;
>  
>      ret = readdir_r(thedir->dirstruct, thedir->entry, &retent);
>  
> -- 
> >~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Kevin Pilch-Bisson
> kevin@pilch-bisson.net
> http://www.pilch-bisson.net
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message