apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apr/network_io/unix sendrecv.c
Date Sun, 07 Jan 2001 00:40:28 GMT

> > Both methods do the same thing.  I decided to put the checks in the code,
> > because I am assuming that at some point we will actually add support for
> > os_cork and os_uncork to the code.  I wanted the special code to disable
> > os_cork and os_uncork as close to the code that would use it as
> > possible.  I figured whoever adds support for os_cork and os_uncork will
> > actually need to look at those functions, so they will see e
> > !defined(__FreeBSD__), whereas if the special check was made in the
> > configure script, that could go un-noticed when the changes were made,
> > thus making it harder for the developer who does the work.
> > 
> > I really don't care which we choose, but the warnings were bugging me, and
> > I wanted them to go away.  :-)
> 
> Makes sense. I've added a reminder to apr/STATUS.

Thanks, I always forget to add reminders.  :-)

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message