apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apr/lib apr_pools.c
Date Wed, 03 Jan 2001 03:56:05 GMT
On Tue, 2 Jan 2001, Greg Stein wrote:

> On Wed, Jan 03, 2001 at 12:53:07AM -0000, rbb@apache.org wrote:
> > rbb         01/01/02 16:53:07
> > 
> >   Modified:    lib      apr_pools.c
> >   Log:
> >   We should not be assigning permanent_pool inside of make_sub_pool.  This
> >   runs the risk of overwriting permanent_pool, which would be VERY bad.  By
> >   moving this back to apr_init_alloc, we know that it should only be called
> >   by apr_initialize.  This does mean that we can NEVER call apr_initialize
> >   twice in the same program, but that should already be taken care of.
> 
> apr_initialize() has a counter to prevent double-initializations from
> happening. This is quite a safe change.

That's what I meant by "but that should already be taken care of."  I
guess the previous statement should have been we can't "execute the meat
of apr_initialize twice in the same program".  Oh well, clarity and I have
never been good friends.  :-)

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message