apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allan Edwards" <...@meepzor.com>
Subject RE: cvs commit: apr/lib apr_pools.c
Date Fri, 05 Jan 2001 19:30:24 GMT
> > I assume the correct fix is to pass in a pool parameter to ap_is_rdirectory.
> > Similar situation seems to exist with apr_stat being passed a NULL pool
> > by ap_is_directory. I'll go ahead and fix these.
> 
> I disagree that this is the correct solution.  APR relies too heavily on
> pools right now, and I think this is causing some of our memory leak.  For
> example, why does apr_get_oslevel take a pool as an argument?  It doesn't

I can't answer for apr_get_oslevel, maybe the pool should go away in that case.
However both apr_stat and apr_lstat need the pool on Windows because of the 
utf8_to_unicode_path call which does use it. 

> use it ever.  That pool should go away.  Once that is done, the pool can
> be removed from apr_stat and apr_lstat.  As far as I can see, the pools
> aren't used there either.
> 

Allan

Mime
View raw message