apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allan Edwards" <...@meepzor.com>
Subject RE: cvs commit: apr/lib apr_pools.c
Date Fri, 05 Jan 2001 18:39:31 GMT
> -----Original Message-----
> From: rbb@apache.org [mailto:rbb@apache.org]
> Sent: Monday, January 01, 2001 8:33 PM
> To: apr-cvs@apache.org
> Subject: cvs commit: apr/lib apr_pools.c
> 
> 
> rbb         01/01/01 17:33:05
> 
>   Modified:    .        CHANGES
>                lib      apr_pools.c
>   Log:
>   Remove the ability to allocate out of a NULL pool.  This was always a bad
>   idea, because it opened up memory leaks.  It is very likely that this will
>   expose some seg faults 

This is indeed true, now that Windows httpd-2.0 is building again it has 
exposed a couple of problems. In ap_is_rdirectory, apr_lstat is passed 
a NULL pool pointer which eventually causes apr_palloc to segfault.

I assume the correct fix is to pass in a pool parameter to ap_is_rdirectory.
Similar situation seems to exist with apr_stat being passed a NULL pool
by ap_is_directory. I'll go ahead and fix these.

Allan

Mime
View raw message