apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr APRVARS.in configure.in
Date Tue, 09 Jan 2001 21:53:23 GMT
That patch is just plain wrong. Usable as a stopgap, but not something to be
committed.

I was dead tired last night and had to crash after some minimal testing.
I'll get the stuff cleaned back up.

Jeff: what is going wrong for you with Ryan's new patch?

Cheers,
-g

On Tue, Jan 09, 2001 at 03:25:35PM -0500, Jeff Trawick wrote:
> rbb@apache.org writes:
> 
> > rbb         01/01/09 11:28:38
> > 
> >   Modified:    .        configure.in
> >                .        APRVARS.in configure.in
> >   Log:
> >   Fix a compile break with the new APR libtool setup.  Basically, we are
> >   using a libtool library from MM, but it isn't getting linked into the
> >   Apache executable, so we fail the link stage.  This makes APR
> >   publicize the libtool libraries that it uses, so that Apache can link
> >   them in.
> 
> This doesn't get it building for me :(
> 
> Before this commit, the patch at the bottom from Victor got us going.
> 
> Index: Makefile.in
> ===================================================================
> RCS file: /home/cvspublic/apr/Makefile.in,v
> retrieving revision 1.37
> diff -u -d -r1.37 Makefile.in
> --- Makefile.in	2001/01/09 11:05:33	1.37
> +++ Makefile.in	2001/01/09 19:38:53
> @@ -42,7 +42,8 @@
>  $(LIBAPR): $(MODULES)
>  	@for i in $(SUBDIRS); do objects="$$objects $$i/*.lo"; done ; \
>  	    echo $(LINK) -rpath $(libdir) $$objects ; \
> -	    $(LINK) -rpath $(libdir) $$objects
> +	    $(LINK) -rpath $(libdir) $$objects ; \
> +            ln -s .libs/libapr.a
>  
>  delete-exports:
>  	@if test -f $(TARGET_EXPORTS); then \
> Index: shmem/unix/Makefile.in
> ===================================================================
> RCS file: /home/cvspublic/apr/shmem/unix/Makefile.in,v
> retrieving revision 1.15
> diff -u -d -r1.15 Makefile.in
> --- shmem/unix/Makefile.in	2001/01/09 11:06:15	1.15
> +++ shmem/unix/Makefile.in	2001/01/09 19:39:59
> @@ -17,11 +17,12 @@
>  # build the MM library, then copy the objects to this dir so our top-level
>  # will find them and copy them to the (top)/objs directory
>  MM_OBJS = \
> -	mm/mm_global.lo mm/mm_alloc.lo mm/mm_core.lo mm/mm_lib.lo \
> -	mm/mm_vers.lo
> +	mm/mm_global.o mm/mm_alloc.o mm/mm_core.o mm/mm_lib.o \
> +	mm/mm_vers.o
>  
>  build-mm:
>  	(cd mm && $(MAKE) libmm.la)
> -	cp $(MM_OBJS) .
> +	@rm -f mm*.o mm*.lo
> +	@for i in $(MM_OBJS); do ln $$i `echo $$i | sed -e 's/.*\/\(.*\)\.o/\1\.lo/'`; done

>  
>  # DO NOT REMOVE
> 
> -- 
> Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
>        http://www.geocities.com/SiliconValley/Park/9289/
>              Born in Roswell... married an alien...

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message