apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/network_io/unix sendrecv.c
Date Sun, 07 Jan 2001 00:25:02 GMT
On Sun, Jan 07, 2001 at 12:00:07AM -0000, rbb@apache.org wrote:
> rbb         01/01/06 16:00:07
> 
>   Modified:    .        CHANGES
>                network_io/unix sendrecv.c
>   Log:
>   We don't actually use os_cork or os_uncork on FreeBSD, so we shouldn't
>   define them.  This removes some warnings.
>...
>   --- sendrecv.c	2001/01/04 22:02:34	1.55
>   +++ sendrecv.c	2001/01/07 00:00:07	1.56
>   @@ -198,7 +198,7 @@
>     * need to move these to the top...
>     */
>    
>   -#if APR_HAVE_CORKABLE_TCP
>   +#if APR_HAVE_CORKABLE_TCP && !defined(__FreeBSD__)
>    
>    /* TCP_CORK & TCP_NOPUSH keep us from sending partial frames when we
>     * shouldn't. They are however, mutually exclusive with TCP_NODELAY  

I don't understand this. Why don't we just /not/ define
APR_HAVE_CORKABLE_TCP on the FreeBSD boxes? (in the ./configure script) That
seems more appropriate than adding platform-specific checks into the code.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message