apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/lib apr_pools.c
Date Wed, 03 Jan 2001 02:14:42 GMT
On Wed, Jan 03, 2001 at 12:53:07AM -0000, rbb@apache.org wrote:
> rbb         01/01/02 16:53:07
> 
>   Modified:    lib      apr_pools.c
>   Log:
>   We should not be assigning permanent_pool inside of make_sub_pool.  This
>   runs the risk of overwriting permanent_pool, which would be VERY bad.  By
>   moving this back to apr_init_alloc, we know that it should only be called
>   by apr_initialize.  This does mean that we can NEVER call apr_initialize
>   twice in the same program, but that should already be taken care of.

apr_initialize() has a counter to prevent double-initializations from
happening. This is quite a safe change.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message