Return-Path: Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Delivered-To: mailing list dev@apr.apache.org Received: (qmail 75475 invoked from network); 14 Dec 2000 19:53:55 -0000 Received: from test.webdav.org (HELO kurgan.lyra.org) (198.144.203.199) by locus.apache.org with SMTP; 14 Dec 2000 19:53:55 -0000 Received: (from gstein@localhost) by kurgan.lyra.org (8.9.3/8.9.3) id LAA01806; Thu, 14 Dec 2000 11:56:46 -0800 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Thu, 14 Dec 2000 11:56:46 -0800 From: Greg Stein To: Jeff Trawick Cc: dev@apr.apache.org Subject: Re: cvs commit: apr STATUS Message-ID: <20001214115646.M8951@lyra.org> Mail-Followup-To: Jeff Trawick , dev@apr.apache.org References: <20001214111036.54641.qmail@locus.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: ; from trawickj@bellsouth.net on Thu, Dec 14, 2000 at 09:48:56AM -0500 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N On Thu, Dec 14, 2000 at 09:48:56AM -0500, Jeff Trawick wrote: > gstein@locus.apache.org writes: > > > gstein 00/12/14 03:10:26 > > > > Modified: . STATUS > > + * apr_create_lock() changes: > ... > > + - The fname param is allowed to be NULL on the Unix platform. > > feature, not bug... Do you mean that the semantics associated with > this ("make up a file for me if you need to, APR") are not implemented > across all platforms? Correct -- all the other platforms require the parameter. > Do you disagree with the usefulness of that feature? Not at all. However, I'd rather see *no* parameter, and the code just always builds its own filename; or I'd rather see the parameter *always* required (because if it can't properly construct the file for some reason, then we better always give it the right one). IOW, if the function knows how to create a filename that will work for the lock (e.g. avoid NFS issues), then why the heck should we pass a value? If it *doesn't* know enough, then we better always pass it, or some goofball that doesn't pass the value is going to get screwed in some edge case. > > + Change it to always use the passed value, and check > > callers. > > It uses the passed value when appropriate, right? Note that we don't > always need a file as not all supported lock mechanisms are > file-based. It uses it when passed, but see above. Cheers, -g -- Greg Stein, http://www.lyra.org/