From rbb@covalent.net Sat Dec 2 01:35:08 2000 Return-Path: Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Delivered-To: mailing list dev@apr.apache.org Received: (qmail 86344 invoked from network); 2 Dec 2000 01:35:08 -0000 Received: from 3ff8faf3.dsl.flashcom.net (HELO koj.covalent.net) (63.248.250.243) by locus.apache.org with SMTP; 2 Dec 2000 01:35:08 -0000 Received: from rbb (helo=localhost) by koj.covalent.net with local-esmtp (Exim 3.16 #1) id 1421bc-0000Am-00; Fri, 01 Dec 2000 17:36:48 -0800 Date: Fri, 1 Dec 2000 17:36:48 -0800 (PST) From: rbb@covalent.net X-Sender: rbb@koj.rkbloom.net To: Greg Stein cc: dev@apr.apache.org Subject: Re: cvs commit: apr/locks/unix locks.c In-Reply-To: <20001201163816.C11548@lyra.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N > > Then please just leave it, and I'll implement the whole thing myself. The > > other option is for you to implement it, and I'll go in immediately and > > change it. > > Why is it that two people ask for the simple one, don't want to do the > harder one (and don't want to see that complexity in there), yet you will > just go and do it anyways? Because APR was designed to be small pieces that don't necessarily know about each other. There is a minimum amount of code that creates cross-dependancies between different sections of APR. It is not that much more complex, and it helps to maintain the abstraction. It is important to me to ensure that each piece of APR can build individually without losing much of it's functionality. By putting all of this into one big function in misc/unix/start.c, you remove that ability, because we rely on misc to report on file_io. Now, go back and read Jeff's reply: > > That is for damn sure :)^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H^H > > I'll start out with all the logic right in cfg.c and as other folks > > have time/inclination they can consider other implementations. I have the time/inclination. That is why I am willing to implement something that I believe is the correct implementation. Personally, I think it is a bit less complex than a single function that is basically one large: #if APR_HAS_THREADS return APR_THREADS_PTHREADS #endif #if APR_HAS_LOCKS return APR_LOCKS_FOOBAR #endif ... I also know that I will be taking small pieces of APR and putting them in my own projects. I will most likely want to have the reporting features that we are talking about. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------