apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: [PATCH] apr_make_os_sock()
Date Sun, 03 Dec 2000 19:18:42 GMT
rbb@covalent.net writes:

> On Sun, 3 Dec 2000, Jeff Trawick wrote:
> 
> > Hopefully I didn't miss any comments on the mailing list last night
> > (where is that archive again?).
> > 
> > Here is enough to look at to make sure I didn't screw anything up.  I
> > added family and type parameters too so that APR doesn't have to bend
> > over backwards (i.e., use syscalls) to find that out.  We don't keep
> > the type anywhere yet but it is likely to become useful in the future.
> 
> I would really prefer that this function at least look like the current
> apr_put_os_* functions.  That would mean just wrapping all of this
> information up into a single structure that is just passed to APR's create
> function.

What is the purpose of putting the parameters into a structure?  Do we
expect that we'll want to tailor the information provided to
apr_make_os_socket() on certain platforms?

I guess I'm not sure what you mean by "APR's create function..."  Do
you want to change apr_create_socket() to take parameters in a
structure, and have the structure indicate whether or not we already
have the OS socket (I don't think this is what you mean).

Should it be apr_make_socket() instead of apr_make_os_socket()?

-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message