apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] Buckets: add copy function, ap_bucket_split_any(), etc
Date Mon, 11 Dec 2000 23:41:26 GMT

> > > Thoughts?
> > 
> > Any error condition should return NULL in ap_brigade_split_offset.
> 
> Also note that we generally don't want to validate arguments and return
> APR_EINVAL. The assumption is the caller passes legal arguments.
> 
> len > brigade-len shouldn't be an error -- it should just be a no-op.

That goes against what we have done with the other bucket functions.  This
is also in general very useful information to have.  We do not want to
validate all arguments, because if it is a programming problem instead of
a logic problem, we don't have to protect against that, but this is
someplace that we have to check the offset regardless, because otherwise
we will seg fault, and the error return code will be very useful to the
caller.  I do believe we want to leave that return code alone.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message