apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] Buckets: add copy function, ap_bucket_split_any(), etc
Date Sat, 09 Dec 2000 23:24:08 GMT

> Question: In the bucket split functions, a sanity check is performed on the point
> passed in: if point is < 0 or > len, APR_EINVAL is returned.  What should be the
> brigade-splitting equivalent of that?  Should an empty brigade be returned, or
> should the return value be NULL to make it more clear that there was an error?  I'm
> leaning toward NULL to distinguish between error cases and the case where the point
> == brigade len.
> 
> Thoughts?

Any error condition should return NULL in ap_brigade_split_offset.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message