apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apr/test occhild.c testdso.c testoc.c testshmem.c
Date Tue, 05 Dec 2000 00:37:37 GMT

>    int main(int argc, char *argv[])
>    {
>   +#if APR_HAS_OTHER_CHILD
>        apr_pool_t *context;
>        apr_proc_t newproc;
>        apr_procattr_t *procattr = NULL;
>   @@ -150,5 +153,9 @@
>        apr_check_other_child();
>        
>        return 1;
>   +#else
>   +    fprintf(stdout, "OC failed!\n");
>   +    fprintf(stdout, "Other_child is not supported on this platform\n");
>   +#endif
>    }    

This needs a return code.


>   +#if APR_HAS_SHARED_MEMORY
>        apr_shmem_t *shm;
>        pid_t pid;
>        int size;
>   @@ -143,4 +146,9 @@
>            fprintf(stderr, "Error creating a child process\n");
>            exit(1);
>        }
>   +#else
>   +    fprintf(stdout, "APR SHMEM test failed!\n");
>   +    fprintf(stdout, "shmem is not supported on this platform\n"); 
>   +    return (-1);
>   +#endif
>    }

Please don't return -1, this will cause APR to say it failed the tests,
when in reality, it just wasn't built with shared memory.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message