apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] apr_make_os_sock()
Date Mon, 04 Dec 2000 14:35:47 GMT

> > Won't it need to be different on different platforms?  I mean, Windows
> > wants a SOCKET, and I wouldn't put it past M$ to change the sockaddr to
> > some windows specific structure in the future.
> The prototype will be the same... that is why we have the apr_os_sock_t
> type.
> We shouldn't need to pass structures to apr_make_os_socket() (or other,
> similar creation functions).

Look again Greg.  The lock stuff already uses structures, because the
amount of information required for creating locks is different based on
the type of lock.  That's where structures really help, and why I would
rather see these functions using structures.  It allows us a bit more
flexability with regard to the different types we can accept.


Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131

View raw message