apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: [PATCH] Buckets: add copy function, ap_bucket_split_any(), etc
Date Sat, 09 Dec 2000 23:19:40 GMT
--- rbb@covalent.net wrote:
> Since brigade_split_offset can't be ENOTIMPL, we can return a brigade.  If
> there is no memory, just return a NULL brigade.

Question: In the bucket split functions, a sanity check is performed on the point
passed in: if point is < 0 or > len, APR_EINVAL is returned.  What should be the
brigade-splitting equivalent of that?  Should an empty brigade be returned, or
should the return value be NULL to make it more clear that there was an error?  I'm
leaning toward NULL to distinguish between error cases and the case where the point
== brigade len.

Thoughts?

--Cliff

__________________________________________________
Do You Yahoo!?
Yahoo! Shopping - Thousands of Stores. Millions of Products.
http://shopping.yahoo.com/

Mime
View raw message